Merge pull request #1168 from DFE-Digital/sum-claims-by-policy-with-a…

…-block

Fix incorrect summing with claims by policy

CHANGELOG.md

@@ -6,6 +6,8 @@ The format is based on [Keep a Changelog]
 
 ## [Unreleased]
 
+- Fix incorrect summing for claims by policy
+
 ## [Release 085] - 2020-10-07
 
 - Update payment email copy

app/models/payroll_run.rb

@@ -21,7 +21,7 @@ def number_of_claims_for_policy(policy)
   end
 
   def total_claim_amount_for_policy(policy)
-    claims.by_policy(policy).sum(:award_amount)
+    claims.by_policy(policy).sum(&:award_amount)
   end
 
   def self.create_with_claims!(claims, attrs = {})

spec/models/payroll_run_spec.rb

@@ -75,11 +75,15 @@
       payment_4 = build(:payment, claims: [
         build(:claim, :approved, eligibility: build(:student_loans_eligibility, :eligible, student_loan_repayment_amount: 1000))
       ])
+      payment_5 = build(:payment, claims: [
+        build(:claim, :approved, teacher_reference_number: "1234567", bank_sort_code: "123456", bank_account_number: "12345678", eligibility: build(:maths_and_physics_eligibility, :eligible)),
+        build(:claim, :approved, teacher_reference_number: "1234567", bank_sort_code: "123456", bank_account_number: "12345678", eligibility: build(:student_loans_eligibility, :eligible, student_loan_repayment_amount: 1000))
+      ])
 
-      payroll_run = PayrollRun.create!(created_by: user, payments: [payment_1, payment_2, payment_3, payment_4])
+      payroll_run = PayrollRun.create!(created_by: user, payments: [payment_1, payment_2, payment_3, payment_4, payment_5])
 
-      expect(payroll_run.total_claim_amount_for_policy(StudentLoans)).to eq(2500)
-      expect(payroll_run.total_claim_amount_for_policy(MathsAndPhysics)).to eq(4000)
+      expect(payroll_run.total_claim_amount_for_policy(StudentLoans)).to eq(3500)
+      expect(payroll_run.total_claim_amount_for_policy(MathsAndPhysics)).to eq(6000)
     end
   end