Merge pull request #2937 from DFE-Digital/fe-teaching-qualification

[LUPEYALPHA-554] add teaching qualification form to FE journey

app/forms/journeys/further_education_payments/teaching_qualification_form.rb

@@ -0,0 +1,39 @@
+module Journeys
+  module FurtherEducationPayments
+    class TeachingQualificationForm < Form
+      attribute :teaching_qualification, :string
+
+      validates :teaching_qualification,
+        presence: {message: i18n_error_message(:inclusion)},
+        inclusion: {in: ->(form) { form.radio_options.map(&:id) }, message: i18n_error_message(:inclusion)}
+
+      def radio_options
+        [
+          OpenStruct.new(
+            id: "yes",
+            name: "Yes"
+          ),
+          OpenStruct.new(
+            id: "not-yet",
+            name: "Not yet, I am currently enrolled on one and working towards completing it"
+          ),
+          OpenStruct.new(
+            id: "no-but-planned",
+            name: "No, but I plan to enrol on one in the next 12 months"
+          ),
+          OpenStruct.new(
+            id: "no-not-planned",
+            name: "No, and I do not plan to enrol on one in the next 12 months "
+          )
+        ]
+      end
+
+      def save
+        return false unless valid?
+
+        journey_session.answers.assign_attributes(teaching_qualification:)
+        journey_session.save!
+      end
+    end
+  end
+end

app/models/journeys/further_education_payments.rb

@@ -15,7 +15,8 @@ module FurtherEducationPayments
         "contract-type" => ContractTypeForm,
         "teaching-hours-per-week" => TeachingHoursPerWeekForm,
         "further-education-teaching-start-year" => FurtherEducationTeachingStartYearForm,
-        "subjects-taught" => SubjectsTaughtForm
+        "subjects-taught" => SubjectsTaughtForm,
+        "teaching-qualification" => TeachingQualificationForm
       }
     }
   end

app/models/journeys/further_education_payments/session_answers.rb

@@ -8,6 +8,7 @@ class SessionAnswers < Journeys::SessionAnswers
       attribute :teaching_hours_per_week, :string
       attribute :further_education_teaching_start_year, :string
       attribute :subjects_taught, default: []
+      attribute :teaching_qualification, :string
 
       def school
         @school ||= School.find(school_id)

app/models/journeys/further_education_payments/slug_sequence.rb

@@ -12,7 +12,7 @@ class SlugSequence
         building-and-construction-courses
         teaching-courses
         half-teaching-hours
-        qualification
+        teaching-qualification
         poor-performance
       ]
 

app/views/further_education_payments/claims/teaching_qualification.html.erb

@@ -0,0 +1,17 @@
+<div class="govuk-grid-row">
+  <div class="govuk-grid-column-two-thirds">
+    <%= form_with model: @form, url: claim_path(current_journey_routing_name), method: :patch, builder: GOVUKDesignSystemFormBuilder::FormBuilder, html: { novalidate: false } do |f| %>
+      <%= f.govuk_error_summary %>
+
+      <%= f.govuk_collection_radio_buttons :teaching_qualification, @form.radio_options, :id, :name,
+        legend: {
+          text: @form.t(:question),
+          tag: "h1",
+          size: "l"
+        },
+        hint: { text: @form.t(:hint) } %>
+
+      <%= f.govuk_submit %>
+    <% end %>
+  </div>
+</div>

config/locales/en.yml

@@ -813,6 +813,11 @@ en:
         hint: Select all that apply
         errors:
           inclusion: Select the subject areas you teach in or select you do not teach any of the listed subject areas
+      teaching_qualification:
+        question: Do you have a teaching qualification?
+        hint: Your response will be noted for future claims. If you don’t have a teaching qualification yet, make sure that you enrol on one or complete one in the next 12 months.
+        errors:
+          inclusion: Select whether you have, are currently enrolled or plan to enrol on a teaching qualification
   activerecord:
     errors:
       models:

spec/features/further_education_payments/happy_js_path_spec.rb

@@ -51,7 +51,8 @@
     expect(page).to have_content("FE half teaching hours goes here")
     click_button "Continue"
 
-    expect(page).to have_content("FE qualification goes here")
+    expect(page).to have_content("Do you have a teaching qualification?")
+    choose("Yes")
     click_button "Continue"
 
     expect(page).to have_content("FE poor performance goes here")

spec/features/further_education_payments/happy_path_spec.rb

@@ -48,7 +48,8 @@
     expect(page).to have_content("FE half teaching hours goes here")
     click_button "Continue"
 
-    expect(page).to have_content("FE qualification goes here")
+    expect(page).to have_content("Do you have a teaching qualification?")
+    choose("Yes")
     click_button "Continue"
 
     expect(page).to have_content("FE poor performance goes here")

spec/forms/journeys/further_education_payments/teaching_qualification_form_spec.rb

@@ -0,0 +1,59 @@
+require "rails_helper"
+
+RSpec.describe Journeys::FurtherEducationPayments::TeachingQualificationForm, type: :model do
+  let(:journey) { Journeys::FurtherEducationPayments }
+  let(:journey_session) { create(:further_education_payments_session) }
+  let(:teaching_qualification) { nil }
+
+  let(:params) do
+    ActionController::Parameters.new(
+      claim: {
+        teaching_qualification:
+      }
+    )
+  end
+
+  subject do
+    described_class.new(
+      journey_session:,
+      journey:,
+      params:
+    )
+  end
+
+  describe "validations" do
+    context "when no option selected" do
+      let(:teaching_qualification) { nil }
+
+      it do
+        is_expected.not_to(
+          allow_value(nil)
+          .for(:teaching_qualification)
+          .with_message("Select whether you have, are currently enrolled or plan to enrol on a teaching qualification")
+        )
+      end
+    end
+
+    context "when non-existent injection option selected" do
+      let(:teaching_qualification) { "foo" }
+
+      it do
+        is_expected.not_to(
+          allow_value("foo")
+          .for(:teaching_qualification)
+          .with_message("Select whether you have, are currently enrolled or plan to enrol on a teaching qualification")
+        )
+      end
+    end
+  end
+
+  describe "#save" do
+    let(:teaching_qualification) { "yes" }
+
+    it "updates the journey session" do
+      expect { expect(subject.save).to be(true) }.to(
+        change { journey_session.reload.answers.teaching_qualification }.to("yes")
+      )
+    end
+  end
+end