use i18n for form options

DFE-Digital · Jul 5, 2024 · daefeb1 · daefeb1
1 parent 57b42b0
commit daefeb1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/app/forms/journeys/further_education_payments/fixed_term_contract_form.rb b/app/forms/journeys/further_education_payments/fixed_term_contract_form.rb
@@ -10,11 +10,11 @@ def radio_options
         [
           OpenStruct.new(
             id: true,
-            name: "Yes, it covers the full #{current_academic_year.to_s(:long)} academic year"
+            name: t("options.true", current_academic_year: current_academic_year.to_s(:long))
           ),
           OpenStruct.new(
             id: false,
-            name: "No, it does not cover the full #{current_academic_year.to_s(:long)} academic year"
+            name: t("options.false", current_academic_year: current_academic_year.to_s(:long))
           )
         ]
       end

diff --git a/app/forms/journeys/further_education_payments/taught_at_least_one_term_form.rb b/app/forms/journeys/further_education_payments/taught_at_least_one_term_form.rb
@@ -13,11 +13,11 @@ def radio_options
         [
           OpenStruct.new(
             id: true,
-            name: "Yes, I have taught at #{school.name} for at least one academic term"
+            name: t("options.true", school_name: school.name)
           ),
           OpenStruct.new(
             id: false,
-            name: "No, I have not taught at #{school.name} for at least one academic term"
+            name: t("options.false", school_name: school.name)
           )
         ]
       end

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -830,10 +830,16 @@ en:
           inclusion: Select the contract type you have
       fixed_term_contract:
         question: Does your fixed-term contract cover the full %{academic_year} academic year?
+        options:
+          true: Yes, it covers the full %{current_academic_year} academic year
+          false: No, it does not cover the full %{current_academic_year} academic year
         errors:
           inclusion: Select yes if your fixed-term contract covers the full academic year
       taught_at_least_one_term:
         question: Have you taught at %{school_name} for at least one academic term?
+        options:
+          true: Yes, I have taught at %{school_name} for at least one academic term
+          false: No, I have not taught at %{school_name} for at least one academic term
         errors:
           inclusion: Select yes if you have taught at %{school_name} for at least one academic term
       teaching_hours_per_week: