-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup the admin to display IRP claims #2911
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
reviewed
Jun 25, 2024
app/models/policies/international_relocation_payments/eligibility.rb
Outdated
Show resolved
Hide resolved
felixclack
force-pushed
the
admin-irp
branch
2 times, most recently
from
June 25, 2024 08:52
f124bc1
to
14dc2a2
Compare
The claimant journey for IRP is now basically wired up #2920 - so if you want to test how claims are coming through to the admin area you can either create a branch off that and merge this PR's changes in or rebase this branch off of |
Adds the employment details page as per IRP. We've named the fields the same as in IRP. We could probably provide a school search box for this but that's something for a future iteration. Have also added the school details to the PII section to be on the safe side as they might be enough to identify an claimant in combination with some of the other non pii answers.
felixclack
force-pushed
the
admin-irp
branch
4 times, most recently
from
June 27, 2024 09:06
506918c
to
b85a7f5
Compare
felixclack
force-pushed
the
admin-irp
branch
4 times, most recently
from
June 27, 2024 10:07
28d2dd8
to
7ab070b
Compare
…duction not completed) (#2766) * Move last policy year value to `Policies::EarlyCareerPayments` For consistency with the Student Loans policy * Move last policy year value to `Policies::LevellingUpPremiumPayments` For consistency with the Student Loans policy Add the first policy year value as well. * Remove redundant methods from `Policies::EarlyCareerPayments` These were created a while ago for consistency with Student Loans, but the meaning here is completely different and misleading. The QTS Award year is not linked to the policy start/end year. * Use `#any_future_policy_years?` to evaluate against the the policy specific end year * Fix eligibility criteria url for ECP * Make sure an ECP claim is ineligible when induction not completed and it's the end year for ECP For years previous to the final one, if a user selected an ECP-only school (meaning the LUPP claim is ineligible), and answered "No" to the induction question, they'd be able to see the eligible-later slug and set up a reminder. * Fix copy * Use session answers instead of claim object * Fix bug in ineligible page * Remove shim class workaround --------- Co-authored-by: Steve Lorek <[email protected]>
Bumps [pagy](https://github.com/ddnexus/pagy) from 8.4.5 to 8.5.0. - [Release notes](https://github.com/ddnexus/pagy/releases) - [Changelog](https://github.com/ddnexus/pagy/blob/master/CHANGELOG.md) - [Commits](ddnexus/pagy@8.4.5...8.5.0) --- updated-dependencies: - dependency-name: pagy dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
In order to be able to display the IRP claims in the admin, there are some basic methods that need to be available. This change ensures the minimum implementation for displaying claims without being concerned about the correctness of the required methods. Specifically the `award_amount` is a placeholder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to display the IRP claims in the admin, there are
some basic methods that need to be available.
This change ensures the minimum implementation for displaying claims
without being concerned about the correctness of the required methods.