Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup the admin to display IRP claims #2911

Closed
wants to merge 6 commits into from
Closed

Setup the admin to display IRP claims #2911

wants to merge 6 commits into from

Conversation

felixclack
Copy link
Contributor

@felixclack felixclack commented Jun 24, 2024

In order to be able to display the IRP claims in the admin, there are
some basic methods that need to be available.

This change ensures the minimum implementation for displaying claims
without being concerned about the correctness of the required methods.

Name Screenshot
Claims Index Screenshot 2024-06-27 at 10 40 01 am
Claim Show Screenshot 2024-06-27 at 10 55 52 am

@felixclack felixclack force-pushed the admin-irp branch 2 times, most recently from f124bc1 to 14dc2a2 Compare June 25, 2024 08:52
@rjlynch
Copy link
Contributor

rjlynch commented Jun 25, 2024

The claimant journey for IRP is now basically wired up #2920 - so if you want to test how claims are coming through to the admin area you can either create a branch off that and merge this PR's changes in or rebase this branch off of CAPT-1736/form-fixes (might not want to rebase this PR, I don't think there would be many conflicts but this PR would get blocked waiting on my chain of PRs!)

Adds the employment details page as per IRP. We've named the fields the
same as in IRP. We could probably provide a school search box for this
but that's something for a future iteration.
Have also added the school details to the PII section to be on the safe
side as they might be enough to identify an claimant in combination with
some of the other non pii answers.
@felixclack felixclack force-pushed the admin-irp branch 4 times, most recently from 506918c to b85a7f5 Compare June 27, 2024 09:06
@felixclack felixclack marked this pull request as ready for review June 27, 2024 09:06
@felixclack felixclack force-pushed the admin-irp branch 4 times, most recently from 28d2dd8 to 7ab070b Compare June 27, 2024 10:07
slorek and others added 5 commits June 27, 2024 11:08
…duction not completed) (#2766)

* Move last policy year value to `Policies::EarlyCareerPayments`

For consistency with the Student Loans policy

* Move last policy year value to `Policies::LevellingUpPremiumPayments`

For consistency with the Student Loans policy

Add the first policy year value as well.

* Remove redundant methods from `Policies::EarlyCareerPayments`

These were created a while ago for consistency with Student Loans, but the meaning here
is completely different and misleading. The QTS Award year is not linked to the policy start/end year.

* Use `#any_future_policy_years?` to evaluate against the the policy specific end year

* Fix eligibility criteria url for ECP

* Make sure an ECP claim is ineligible when induction not completed and it's the end year for ECP

For years previous to the final one, if a user selected an ECP-only school (meaning the LUPP claim is ineligible),
and answered "No" to the induction question, they'd be able to see the eligible-later slug and set up a reminder.

* Fix copy

* Use session answers instead of claim object

* Fix bug in ineligible page

* Remove shim class workaround

---------

Co-authored-by: Steve Lorek <[email protected]>
Bumps [pagy](https://github.com/ddnexus/pagy) from 8.4.5 to 8.5.0.
- [Release notes](https://github.com/ddnexus/pagy/releases)
- [Changelog](https://github.com/ddnexus/pagy/blob/master/CHANGELOG.md)
- [Commits](ddnexus/pagy@8.4.5...8.5.0)

---
updated-dependencies:
- dependency-name: pagy
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
In order to be able to display the IRP claims in the admin, there are
some basic methods that need to be available.

This change ensures the minimum implementation for displaying claims
without being concerned about the correctness of the required methods.
Specifically the `award_amount` is a placeholder.
@felixclack felixclack closed this Jun 27, 2024
@felixclack felixclack deleted the admin-irp branch June 27, 2024 10:58
@felixclack felixclack restored the admin-irp branch June 27, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants