Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LUPEYALPHA-550] Add academic start year form for FE journey #2924

Merged
merged 1 commit into from
Jul 2, 2024
Merged

[LUPEYALPHA-550] Add academic start year form for FE journey #2924

merged 1 commit into from
Jul 2, 2024

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Jun 26, 2024 •
edited
Loading

Context

Changes

  • Added which academic year started teaching FE in FE journey
  • I've tweaked the slug so it is more descriptive

@asmega asmega marked this pull request as ready for review June 26, 2024 11:09
rjlynch
rjlynch approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

app/forms/journeys/further_education_payments/further_education_teaching_start_year_form.rb Show resolved Hide resolved
app/views/further_education_payments/claims/further_education_teaching_start_year.html.erb Show resolved Hide resolved
@asmega asmega added the deploy Deploy a review app for this PR label Jul 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-2924-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-2924-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-2924-web.test.teacherservices.cloud/further-education-payments/landing-page
Admin https://claim-additional-payments-for-teaching-review-2924-web.test.teacherservices.cloud/admin

@asmega asmega merged commit db317ae into master Jul 2, 2024
16 checks passed
@asmega asmega deleted the fe-start-year branch July 2, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

@slorek slorek slorek approved these changes

Assignees
No one assigned
Labels
deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asmega @slorek @rjlynch