[LUPEYALPHA-555] Add poor performance form to FE journey #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmega
force-pushed
the
fe-poor-performance
branch
from
14492d2 to
f6ceaf0
Compare
slorek
reviewed
Jun 28, 2024
There was a problem hiding this comment.
Can we re-use the Journeys::AdditionalPaymentsForTeaching::PoorPerformanceForm form object? We can move that out of the journey specific namespace so it can be re-used.
Generally, we would want to do this and then override where necessary. This includes view templates and copy strings as well.
asmega
force-pushed
the
fe-poor-performance
branch
from
f6ceaf0 to
d37a5e9
Compare
done |
slorek
approved these changes
Jul 2, 2024
- a single poor performance form that is now shared between journeys - refactored to use GOVUK formbuilder
asmega
force-pushed
the
fe-poor-performance
branch
from
d37a5e9 to
1c12a17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes
poor_performanceform that is shared betweenpoor_performanceform now uses GOVUK formbuilder