Add eligibility check for contract start date #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorek
approved these changes
Jun 28, 2024
app/models/policies/international_relocation_payments/eligibility.rb
Outdated
Show resolved
Hide resolved
We want to reject claimants if their contract start date is earlier than 6 months before the autumn term. This commit updates the eligibility checker to do so and also adds some missing tests.
We eventually want to get rid of the policy models, storing their data on the claim itself, so the policy eligibility checker is a better home for this method.
rjlynch
force-pushed
the
CAPT-1747/reject-ineligible-contract-start-dates
branch
from
d97e6e1 to
bceb2da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to reject claimants if their contract start date is earlier than
6 months before the autumn term. This commit updates the eligibility
checker to do so and also adds some missing tests.
Walk through
contract-start-date.mov