Purge unsubmitted journey sessions #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
commented
Jul 1, 2024
| old_submitted_claim = create(:claim, :submitted, updated_at: over_24_hours_ago) | ||
| Journeys::JOURNEYS.each do |journey| | ||
| submitted_journeys << journey::Session.create!( | ||
| journey: journey::ROUTING_NAME, |
There was a problem hiding this comment.
I think we might want to consider switching from storing the journey on the journey session like this to proper STI. (Not sure if it's worth the effort as I don't expect us to do much querying on the journey session table)
slorek
approved these changes
Jul 2, 2024
rjlynch
force-pushed
the
CAPT-1750/purge-unsubmitted-journey-sessions
branch
from
d6327ee to
f1d6821
Compare
Now we only create a claim once the claimant has completed the journey we need to update the purge job to work on journey sessions rather than claims as all claims are submitted claims.
rjlynch
force-pushed
the
CAPT-1750/purge-unsubmitted-journey-sessions
branch
from
f1d6821 to
f39ab4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we only create a claim once the claimant has completed the journey
we need to update the purge job to work on journey sessions rather than
claims as all claims are submitted claims.