Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUPEYALPHA-1170] EY full claim view #3338

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Conversation

alkesh
Copy link
Contributor

@alkesh alkesh commented Oct 23, 2024

  • save provider_email_address, award_amount, returner_worked_with_children, returner_contract_type, award_amount when the provider submits the claim
  • admin full claim view works for both provider submitted claims, and practitioner submitted claims
  • removed Claim.submitted scope (useful for EY, because the provider submitted claim has no submitted_at - this is populated when the practitioner submits the claim.
  • email_address is not populated on the claim when the provider submits the claim, only when the practitioner does.

@alkesh alkesh force-pushed the LUPEYALPHA-1170-EY-full-claim-view branch from 0a4aa97 to 5d3dc31 Compare October 23, 2024 15:55
@alkesh alkesh added the deploy Deploy a review app for this PR label Oct 23, 2024
@alkesh alkesh force-pushed the LUPEYALPHA-1170-EY-full-claim-view branch from 5d3dc31 to 7736fbd Compare October 24, 2024 08:48
@@ -31,10 +31,6 @@ def update_after_three_weeks_lup
ClaimMailer.update_after_three_weeks(claim_for(Claim.approved.by_policy(Policies::LevellingUpPremiumPayments)))
end

def email_verification
ClaimMailer.email_verification(claim_for(Claim.unsubmitted), OneTimePassword::Generator.new.code)
end
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we use these mailer previews? none of them work for me locally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't use em, happy for them to go

@alkesh alkesh force-pushed the LUPEYALPHA-1170-EY-full-claim-view branch from 390e339 to fdc77de Compare October 24, 2024 14:54
@alkesh alkesh force-pushed the LUPEYALPHA-1170-EY-full-claim-view branch from fdc77de to 5dead11 Compare October 25, 2024 09:45
@alkesh alkesh force-pushed the LUPEYALPHA-1170-EY-full-claim-view branch from 5dead11 to 594865f Compare October 25, 2024 09:51
@alkesh alkesh force-pushed the LUPEYALPHA-1170-EY-full-claim-view branch from 594865f to ee90cba Compare October 25, 2024 14:00
@alkesh alkesh force-pushed the LUPEYALPHA-1170-EY-full-claim-view branch from ee90cba to 1845ca5 Compare October 28, 2024 14:08
@alkesh alkesh merged commit 9c1a3cd into master Oct 28, 2024
14 checks passed
@alkesh alkesh deleted the LUPEYALPHA-1170-EY-full-claim-view branch October 28, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploy a review app for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants