Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LUPEYALPHA-1235] Rejecting EY claim also emails provider #3360

Merged
merged 2 commits into from
Nov 1, 2024
Merged

[LUPEYALPHA-1235] Rejecting EY claim also emails provider #3360

merged 2 commits into from
Nov 1, 2024

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Oct 31, 2024 •
edited
Loading

Context

Review notes

  • I'm aware that at this moment ClaimMailer is not in the best of shape and rather overloaded. I think at some point we need to add some kind of service class(es) to deal with business logic of when to send email leaving mail just to deal with mail

@asmega asmega added the deploy Deploy a review app for this PR label Oct 31, 2024
@github-actions GitHub Actions
Copy link

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3360-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3360-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3360-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3360-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3360-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3360-web.test.teacherservices.cloud/admin

@asmega asmega force-pushed the ey-provider-rejection-email branch from 3573d7a to 38f210a Compare October 31, 2024 14:10
@asmega asmega changed the title rejecting EY claim also emails provider [LUPEYALPHA-1235] Rejecting EY claim also emails provider Oct 31, 2024
@asmega asmega marked this pull request as ready for review October 31, 2024 15:23
rjlynch
rjlynch approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ClaimMailer is not in the best of shape and rather overloaded

Yeah I think we probably want some policy specific mailers

@asmega asmega force-pushed the ey-provider-rejection-email branch 2 times, most recently from 83addb3 to fd62d81 Compare November 1, 2024 10:10
@asmega asmega force-pushed the ey-provider-rejection-email branch from fd62d81 to 381912a Compare November 1, 2024 10:22
@asmega asmega force-pushed the ey-provider-rejection-email branch from db03bfe to dcdd633 Compare November 1, 2024 11:43
rjlynch
rjlynch approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@asmega asmega merged commit eb1b25a into master Nov 1, 2024
17 checks passed
@asmega asmega deleted the ey-provider-rejection-email branch November 1, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

Assignees
No one assigned
Labels
business reviewed deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmega @rjlynch