Send emails when claim approved #3410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmega
reviewed
Nov 15, 2024
| @@ -25,7 +25,7 @@ def auto_approve! | |||
| claim.notes.create!(body: "This claim has been marked for a quality assurance review") | |||
| end | |||
|
|
|||
| ClaimMailer.approved(claim).deliver_later unless claim.awaiting_qa? | |||
| claim.policy.mailer.approved(claim).deliver_later unless claim.awaiting_qa? | |||
There was a problem hiding this comment.
so will not call deliver_later on
self.class.provider_approved(claim).deliver_later
does it work as expected? I feel like we still need something in between the mailer and whatever calls the mailer to handle the events lifecycle. I was able to get away with not doing it in a recent change. maybe this just crosses the line? tbh i'm not sure what this thing would look like though
There was a problem hiding this comment.
The emails are sent to the provider and practitioner as expected.
I think what we really want to do is
claim.policy.claim_approved(claim)
(and claim.policy.claim_rejected(claim) etc)
and let the policy decide what emails to send / other actions to take when a claim is approved. Not sure if this should be part of this pr or in a separate pr.
asmega
approved these changes
Nov 19, 2024
When an EY claim is approved we want to send an email to the practitioner and the provider. Mailers don't let us send two email from one action, so the approve method enqueues jobs to send each of the emails. I think it would probably be better for policies to be told a claim has been approved and handle policy specific actions like sending emails in the polciy, so rather than: `@claimpolicy.mailer.approved(@claim).deliver_later` we'd do `@claim.policy.claim_approved(@claim)` and let the policy determine the action to take (sending emails). However this is a bit different to how we do things now, so for the time being we'll just call the mailer, even it it's a bit odd and sends two emails.
rjlynch
force-pushed
the
CAPT-1989/claim-approved-email
branch
from
c618cd0 to
003707a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an EY claim is approved we want to send an email to the
practitioner and the provider.
Mailers don't let us send two email from one action, so the approve
method enqueues jobs to send each of the emails.
I think it would probably be better for policies to be told a claim has
been approved and handle policy specific actions like sending emails in
the polciy, so rather than:
@claimpolicy.mailer.approved(@claim).deliver_laterwe'd do
@claim.policy.claim_approved(@claim)and let the policy determine the action to take (sending emails).
However this is a bit different to how we do things now, so for the time
being we'll just call the mailer, even it it's a bit odd and sends two
emails.