Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAPT-1915] Improve admin allocations #3411

Merged
merged 4 commits into from
Nov 21, 2024
Merged

[CAPT-1915] Improve admin allocations #3411

merged 4 commits into from
Nov 21, 2024

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Nov 15, 2024

Context

Other changes

  • use govuk formbuilder for allocations form
  • some simple tidying up:
    • removing duplicate code
    • using multi line method calls over long single line method calls

@asmega asmega added the deploy Deploy a review app for this PR label Nov 15, 2024
@github-actions GitHub Actions
Copy link

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3411-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3411-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3411-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3411-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3411-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3411-web.test.teacherservices.cloud/admin

@asmega asmega changed the title [CAPT-1915] Improvde admin allocations [CAPT-1915] Improve admin allocations Nov 15, 2024
@asmega asmega marked this pull request as ready for review November 15, 2024 15:53
rjlynch
rjlynch approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@asmega asmega merged commit a0a42d8 into master Nov 21, 2024
14 checks passed
@asmega asmega deleted the better-allocate branch November 21, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

Assignees
No one assigned
Labels
business reviewed deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmega @rjlynch