Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAPT-1323] Upgrade rails 7.0.8.5 => 7.1.5 #3421

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[CAPT-1323] Upgrade rails 7.0.8.5 => 7.1.5 #3421

merged 2 commits into from
Nov 25, 2024

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Nov 21, 2024 •
edited
Loading

Context

Notes

  • Some weirdness with travel_to. Date never works and need to travel a bit forward or backwards beyond threshold for tests to pass

@asmega asmega added the deploy Deploy a review app for this PR label Nov 21, 2024
@asmega asmega force-pushed the rails-7-1 branch 3 times, most recently from 532b64a to 79ab09c Compare November 21, 2024 12:57
@github-actions GitHub Actions
Copy link

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3421-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3421-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3421-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3421-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3421-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3421-web.test.teacherservices.cloud/admin

@asmega asmega changed the title upgrade rails 7.0.8.5 => 7.1.5 [CAPT-1323] Upgrade rails 7.0.8.5 => 7.1.5 Nov 21, 2024
@asmega asmega marked this pull request as ready for review November 21, 2024 17:02
rjlynch
rjlynch approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice thing about a JS light app is upgrades shouldn't break in subtle ways!

Dockerfile Outdated Show resolved Hide resolved
@asmega asmega merged commit 911cd67 into master Nov 25, 2024
14 checks passed
@asmega asmega deleted the rails-7-1 branch November 25, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

Assignees
No one assigned
Labels
deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmega @rjlynch