Remove policies_claimable #3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
force-pushed
the
CAPT-2065/match-irp-claims
branch
from
d0712bf to
fa8e7b2
Compare
Open
slorek
approved these changes
Dec 20, 2024
This constant was introduced in e25c92f to handle policies not having a trn (part of the moving trn from claim to eligibility work). 806c202 introduced some logic to only compare eligibility attributes that both policies have in common and so the policies_claimable constant is redundant. We always want to show a matching claim alert in the admin area even if the policy combination is invalid (eg can't claim for both irp & fe), thus there is no need to limit the policies we look for matches against.
rjlynch
force-pushed
the
CAPT-2065/match-irp-claims
branch
from
fa8e7b2 to
62c0910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constant was introduced in e25c92f to handle policies not having a
trn (part of the moving trn from claim to eligibility work).
806c202 introduced some logic to only compare eligibility attributes
that both policies have in common and so the policies_claimable constant
is redundant.
We always want to show a matching claim alert in the admin area even if
the policy combination is invalid (eg can't claim for both irp & fe),
thus there is no need to limit the policies we look for matches against.