Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate gcp wif #3481

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Migrate gcp wif #3481

merged 1 commit into from
Jan 6, 2025

Conversation

neillturner
Copy link
Contributor

Context

Migrate application to use gcp wif

Changes proposed in this pull request

Adding identity federation for google cloud authentication and big query

Guidance to review

review changes.

access review app

check events flowing to GCP

Link to Trello card

Claims: migrate to GCP WIF

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

Copy link

@vipin-dfe vipin-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@neillturner neillturner merged commit 09303fd into master Jan 6, 2025
15 checks passed
@neillturner neillturner deleted the gcp-wif branch January 6, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploy a review app for this PR devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants