Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAPT-2090] Add nil guard where eligible_itt_subject is nil #3485

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Jan 3, 2025

Context

@asmega asmega marked this pull request as ready for review January 3, 2025 09:49
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm not sure if an ECP claim should be able to be submitted without an eligible_itt_subject. Looks like the claim that triggered this error was some sort of dupe and the other claim from the claimant was approved

@asmega
Copy link
Contributor Author

asmega commented Jan 3, 2025

LGTM, though I'm not sure if an ECP claim should be able to be submitted without an eligible_itt_subject. Looks like the claim that triggered this error was some sort of dupe and the other claim from the claimant was approved

Yeah, i'm not really sure, at least this way we don't throw an error and page can at least load

@asmega asmega merged commit 42f2916 into master Jan 3, 2025
15 checks passed
@asmega asmega deleted the admin-nil-guard branch January 3, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants