[CPDLP-3000] Create magic dates to create validated ECTs and mentors in the 2024 cohort #4734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://cpd-ecf-review-4734-web.test.teacherservices.cloud |
leandroalemao
force-pushed
the
CPDLP-3000
branch
from
c408ba5 to
ca6fdb6
Compare
cwrw
reviewed
May 7, 2024
app/services/dqt_record_check.rb
Outdated
| @@ -133,6 +133,12 @@ def magic_results | |||
|
|
|||
| # all matches 23 cohort start date - use 23/1/1900 | |||
| 23 => CheckResult.new(magic_dqt_record(induction_start_date: Date.new(2023, 9, 1)), true, true, true, true, 4), | |||
|
|
|||
| # all matches 23 cohort start date - use 24/1/1900 | |||
There was a problem hiding this comment.
Suggested change
| # all matches 23 cohort start date - use 24/1/1900 | |
| # all matches 24 cohort start date - use 24/1/1900 |
cwrw
reviewed
May 7, 2024
app/services/dqt_record_check.rb
Outdated
| # all matches 23 cohort start date - use 24/1/1900 | ||
| 24 => CheckResult.new(magic_dqt_record(induction_start_date: Date.new(2024, 9, 1)), true, true, true, true, 4), | ||
|
|
||
| # all matches 25 cohort start date - use 25/1/1900 |
There was a problem hiding this comment.
might be worth adding this to the readme if we're going with this, or waiting till next year :)
cwrw
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We'd like to create a magic date that providers and DfE users can create validated, eligible for funding mentors and ECT’s in the 2024 cohort.
Changes proposed in this pull request
Create magic dates to create validated ECT's and mentors in the 2024 cohort.