[CST-2554] (part 2) Allow completed declarations to overwrite started not completed declarations until 31st July. #4829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://cpd-ecf-review-4829-web.test.teacherservices.cloud |
leoapost
approved these changes
May 22, 2024
steventux
approved these changes
May 22, 2024
tonyheadford
deleted the
allow_mentor_completions_to_override_rule3_completion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Mentors::CheckTrainingCompletionservice to prevent overwriting a manually added "started not completed" completion when acompleteddeclaration is received after 31st July. Until that date a completed declaration should override the completion date and reason if it has been marked as a "started not completed" completion.Changes proposed in this pull request
Adds logic to the completion check service.
Guidance to review