Pin azurerm version to 3.104.2 as the latest 3.105.0 version made the build to fail #4844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://cpd-ecf-review-4844-web.test.teacherservices.cloud |
|
Would setting the variable in our project here not work? probably need to do it for the snapshot DB too https://github.com/DFE-Digital/npq-registration/blob/main/terraform/application/database.tf#L28 |
ethax-ross
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We're fetching the latest version of
azurerm 3.105.0which is now defaultingpublic_network_access_enabledfrom false to true.public_network_access_enabled = false -> truehttps://github.com/DFE-Digital/early-careers-framework/actions/runs/9222398909/job/25374325095
Changes proposed in this pull request
We need to pin/fix the version to the previous version
3.104.2for now.Ideally we'd need to set the variable as false in module https://github.com/DFE-Digital/terraform-modules/blob/main/aks/postgres/resources.tf#L39 but that'd cause many projects to get upgraded.