Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CST-2558: newly registered participants with induction start date in … #4853

Conversation

ltello
Copy link
Contributor

@ltello ltello commented May 28, 2024

…payments-frozen cohort are now placed in the cohort currently open for registration

Context

As part of the journey that allows a SIT to add a new ECT to their school there is some logic behind the scenes to determine and sit the participant in a provisional/temporary cohort.

We need to extend that logic to sit in 2024/25 cohort a potential new participant whose DQT induction start date at the time of registration would sit the participant in 2021/22 cohort.

Changes proposed in this pull request

Guidance to review

Copy link

Review app deployed to https://cpd-ecf-review-4853-web.test.teacherservices.cloud

@ltello ltello force-pushed the CST-2558-closing-2021-add-ect-journey-take-into-account-2021-closing-in-cohort-determination-logic branch from 6b0de03 to 4da6d12 Compare May 28, 2024 07:04
@ltello ltello force-pushed the CST-2558-closing-2021-add-ect-journey-take-into-account-2021-closing-in-cohort-determination-logic branch from 4da6d12 to 4b01310 Compare May 28, 2024 08:07
@ltello ltello force-pushed the CST-2558-closing-2021-add-ect-journey-take-into-account-2021-closing-in-cohort-determination-logic branch from 4b01310 to 9e7a74f Compare May 28, 2024 11:49
@ltello ltello force-pushed the CST-2558-closing-2021-add-ect-journey-take-into-account-2021-closing-in-cohort-determination-logic branch from 9e7a74f to 99dbfed Compare May 28, 2024 15:07
@ltello ltello force-pushed the CST-2558-closing-2021-add-ect-journey-take-into-account-2021-closing-in-cohort-determination-logic branch 2 times, most recently from b78d2d9 to 2c2db86 Compare May 29, 2024 18:35
@ltello ltello requested a review from steventux May 29, 2024 18:42
@ltello ltello marked this pull request as ready for review May 29, 2024 21:42
…payments-frozen cohort are now placed in the cohort currently open for registration
@ltello ltello force-pushed the CST-2558-closing-2021-add-ect-journey-take-into-account-2021-closing-in-cohort-determination-logic branch from 2c2db86 to 77a3410 Compare May 29, 2024 21:42
@ltello ltello changed the base branch from main to CST-2580-skip-start-term-step May 29, 2024 21:43
@ltello ltello closed this May 29, 2024
@ltello ltello deleted the CST-2558-closing-2021-add-ect-journey-take-into-account-2021-closing-in-cohort-determination-logic branch May 30, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant