Write use of method_missing in page objects helper to file
#4859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://cpd-ecf-review-4859-web.test.teacherservices.cloud |
steventux
force-pushed
the
log-magic-page-object-methods
branch
from
f00b710 to
a0bb34e
Compare
Instead of filling stdout with messages about these missing page object method calls, log them in a file per RSpec suite run.
steventux
force-pushed
the
log-magic-page-object-methods
branch
from
a0bb34e to
7057fa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We get a lot of
putsmessages about calls to missing page object methods which write to stdout.Changes proposed in this pull request
Instead of filling stdout with messages about these missing page object method calls, log them in a file per RSpec suite run.
Guidance to review