Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CST-2558: closing 2021 - add ect journey - take into account 2021 closing in cohort determination logic #4861

Conversation

ltello
Copy link
Contributor

@ltello ltello commented May 29, 2024

Context

As part of the journey that allows a SIT to add a new ECT to their school there is some logic behind the scenes to determine and sit the participant in a provisional/temporary cohort.

We need to extend that logic to sit in 2024/25 cohort a potential new participant whose DQT induction start date at the time of registration would sit the participant in 2021/22 cohort.

Changes proposed in this pull request

Guidance to review

steventux added 4 commits May 29, 2024 19:40
When a participant has no induction start date from DQT and the current date is within the registration window for the next cohort, automatically assign them.
When adding mentors or ECTs (without induction start date) and
training setup is needed, the wizard flow should take the user to the
approriate step.
Copy link

Review app deployed to https://cpd-ecf-review-4861-web.test.teacherservices.cloud

@ltello ltello changed the base branch from main to CST-2580-skip-start-term-step May 29, 2024 21:55
@ltello ltello requested a review from steventux May 29, 2024 23:48
@ltello ltello changed the title Cst 2558 closing 2021 add ect journey take into account 2021 closing in cohort determination logic 2 CST-2558: closing 2021 add ect journey take into account 2021 closing in cohort determination logic 2 May 30, 2024
Copy link
Contributor

@steventux steventux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add a feature spec scenario for payments frozen but given the simplicity of this change I think that can be done later as part of the wider test coverage.

@ltello ltello changed the title CST-2558: closing 2021 add ect journey take into account 2021 closing in cohort determination logic 2 CST-2558: closing 2021 - add ect journey - take into account 2021 closing in cohort determination logic May 30, 2024
@ltello ltello force-pushed the CST-2580-skip-start-term-step branch from cd1d663 to 5b7cb6c Compare May 30, 2024 14:12
@ltello ltello merged commit 723ca3c into CST-2580-skip-start-term-step May 30, 2024
73 checks passed
@ltello ltello deleted the CST-2558-closing-2021-add-ect-journey-take-into-account-2021-closing-in-cohort-determination-logic-2 branch May 30, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants