Show reason for challenge to admins when partnership already exists #4892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://cpd-ecf-review-4892-web.test.teacherservices.cloud |
leoapost
force-pushed
the
enhance-admin-existing-partnership-view
branch
3 times, most recently
from
9e11008 to
6114d4a
Compare
leoapost
force-pushed
the
enhance-admin-existing-partnership-view
branch
from
6114d4a to
3630a60
Compare
tonyheadford
reviewed
Jun 5, 2024
| <% end %> | ||
| <% summary_list.with_row do |row| %> | ||
| <% row.with_key { "Challenge reason" } %> | ||
| <% row.with_value { @wizard.existing_partnership.challenge_reason } %> |
There was a problem hiding this comment.
Could we translate these into plain English for display instead of underscored code-y values?
There was a problem hiding this comment.
Only super users will see this information, and they are likely to reach out to developers for support. So, I thought raw values would be easier for troubleshooting.
Happy to use the English translations instead, but I'll most likely run a search each time in the code to figure out the raw values :)
There was a problem hiding this comment.
Even something like @wizard.existing_partnership.challenge_reason.humanize is better and probably enough?
To provide more context to super users why the partnership can't be created.
leoapost
force-pushed
the
enhance-admin-existing-partnership-view
branch
from
3630a60 to
db01c8f
Compare
tonyheadford
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Enhance context for displaying the "This relationship already exists" page when Admins attempt to change participants' LP/DP in an already existing and challenged partnership.
Changes proposed in this pull request
Guidance to review