Add X-With-Server-Date header support to migration env #4905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwrw
reviewed
Jun 7, 2024
config/environments/migration.rb
Outdated
|
|
||
| # Used to handle HTTP_X_WITH_SERVER_DATE header for server side datetime overwrite | ||
| config.middleware.use TimeTraveler | ||
| config.middleware.use ApiRequestMiddleware |
There was a problem hiding this comment.
Not sure we need this one as it creates ApiRequest?
cwrw
approved these changes
Jun 7, 2024
We need this to be able to test some of the declaration scenarios.
ethax-ross
force-pushed
the
migration-server-date-header
branch
from
e116d2f to
5ac64f8
Compare
|
Review app deployed to https://cpd-ecf-review-4905-web.test.teacherservices.cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this to be able to test some of the declaration scenarios.