[CPDLP-3818] Remove data in shared ecf declaration tables for npq #5401
Conversation
|
Review app deployed to https://cpd-ecf-review-5401-web.test.teacherservices.cloud |
There was a problem hiding this comment.
@mooktakim All looks good.. a minor comment on cleaning en.yml file as well if you want.
| @@ -3,7 +3,7 @@ | |||
| class DetectSidekiqMetricsIssuesJob | |||
| include Sidekiq::Worker | |||
|
|
|||
| SIDEKIQ_QUEUE_NAMES = %w[priority_mailers mailers default participant_outcomes big_query].freeze | |||
There was a problem hiding this comment.
maybe we can remove outcomes from fixtures? fixtures/files/api_reference/api_spec.json
| @@ -3,7 +3,7 @@ | |||
| class FutureDateValidator < ActiveModel::EachValidator | |||
| def validate_each(record, attribute, value) | |||
| if value && value > Time.zone.now | |||
| record.instance_of?(::ParticipantOutcome::NPQ) ? record.errors.add(attribute, I18n.t(:future_date_outcomes, attribute:)) : record.errors.add(attribute, I18n.t(:future_date, attribute:)) | |||
There was a problem hiding this comment.
I think we can drop future_date_outcomes from the translations file
There was a problem hiding this comment.
There are also some other translations we can probably bin:
https://github.com/DFE-Digital/early-careers-framework/blob/main/config/locales/en.yml#L186
https://github.com/DFE-Digital/early-careers-framework/blob/main/config/locales/en.yml#L706
Maybe we just do a sweep of these separately though 🤔
There was a problem hiding this comment.
I think those are in the sweep later so its ok :)
mooktakim
force-pushed
the
3814-npq-post-separation-cleanup-remove-npq-specific-tables-from-ecf
branch
2 times, most recently
from
856360e to
673893e
Compare
mooktakim
force-pushed
the
3818-remove-data-in-shared-ecf-declaration-tables-for-npq
branch
from
7d5d1c9 to
a57b49f
Compare
mooktakim
force-pushed
the
3818-remove-data-in-shared-ecf-declaration-tables-for-npq
branch
from
a57b49f to
b571092
Compare
Context
Changes proposed in this pull request
ParticipantOutcomeApiRequestParticipantOutcome::NPQDeclarationStateParticipantDeclarationAttemptParticipantDeclarationGuidance to review