Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPDLP-3889] Spike: How do we remove uplifts from ECT calculations #5411

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[CPDLP-3889] Spike: How do we remove uplifts from ECT calculations #5411

wants to merge 1 commit into from
+62 −40

Conversation

mooktakim
Copy link
Contributor

Context

Changes proposed in this pull request

  • Set CallOffContract.uplift_amount to nil to disable uplift fees
  • Updated statement and calculator to only calculate uplift if include_uplift_fees? is true

Guidance to review

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Review app deployed to https://cpd-ecf-review-5411-web.test.teacherservices.cloud

@mooktakim mooktakim added the blocked-merge Do not merge this PR label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked-merge Do not merge this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mooktakim