Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER-895 Local Authority User data discrepancy #1019

Merged
merged 3 commits into from
Dec 21, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/data_analysis/local_authority_user.rb
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@ def authorities

# @return [User::ActiveRecord_Relation]
def public_beta_users
User.since_public_beta.with_local_authority
User.since_public_beta.with_local_authority.registration_complete
end
end
end
4 changes: 4 additions & 0 deletions spec/models/data_analysis/local_authority_user_spec.rb
Original file line number Diff line number Diff line change
@@ -22,6 +22,10 @@
end

before do
# Incomplete registration
create :user, :named, local_authority: 'LA3'

# Registered user
create :user, :registered, local_authority: 'LA1'
create :user, :registered, local_authority: 'LA1'
create :user, :registered, local_authority: 'LA3'