Added CancellationToken
support to Historical Expenditure/Census endpoints in API
#1687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AB#242727 AB#237633
Change proposed in this pull request
For the above endpoints only in the Insight function app, support the cancellation of the underlying SQL queries when the client aborts the request. This can be rolled out elsewhere when needed via consumption and propagation of the
CancellationToken
from Function, through Service to Query. To prevent excessive errors in the logs, theTaskCanceledException
logs atInformation
level instead ofError
via custom exception handling middleware that again could be rolled out everywhere (existing try/catches in functions will need to be removed).Guidance to review
To validate, use Swagger UI to test the above endpoints and close/refresh the page during execution (the 'Cancel' button in Swagger UI does not abort the request). Other clients such as Postman may support aborting the request in a better fashion.
Checklist (add/remove as appropriate)
You have reviewed with UX/Design