Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pipeline e2 e tests #852

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

Faizan-ahmad00
Copy link
Collaborator

@Faizan-ahmad00 Faizan-ahmad00 commented May 31, 2024

Context

added raw and expected files for SAT AB#211971 and added raw files for MAT and Maintained schools

Change proposed in this pull request

updated pipeline e2e tests to run the loading single academy trust data and added raw files for maintained and MAT.

Guidance to review

later tests will build on top of these.

Checklist

  • Work items have been linked (use AB#)
  • Your code builds clean without any errors or warnings
  • You have run all unit/integration tests and they pass
  • Your branch has been rebased onto main
  • You have tested by running locally

@Faizan-ahmad00 Faizan-ahmad00 requested a review from colinbull May 31, 2024 09:57
@Faizan-ahmad00 Faizan-ahmad00 force-pushed the feat/pipeline_E2E_Tests branch from 23c558e to db051f3 Compare June 3, 2024 11:17
@Faizan-ahmad00 Faizan-ahmad00 force-pushed the feat/pipeline_E2E_Tests branch from 8e38176 to 3248bde Compare June 3, 2024 11:27
@Faizan-ahmad00 Faizan-ahmad00 marked this pull request as ready for review June 3, 2024 11:28
@PsypherPunk
Copy link
Collaborator

@Faizi52996, is this still good to merge? If so, it just needs the conflict resolving.

@Faizan-ahmad00 Faizan-ahmad00 marked this pull request as draft July 23, 2024 12:19
@Faizan-ahmad00
Copy link
Collaborator Author

@PsypherPunk , converted it to draft for now as it still further work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants