refactor: wrap logic into method

DFE-Digital · Jan 23, 2025 · b0b8f58 · b0b8f58
1 parent 5b43879
commit b0b8f58
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/...nect-ui/src/FamilyHubs.Referral.Web/Pages/ProfessionalReferral/LocalOfferDetail.cshtml.cs b/...nect-ui/src/FamilyHubs.Referral.Web/Pages/ProfessionalReferral/LocalOfferDetail.cshtml.cs
@@ -2,7 +2,6 @@
 using FamilyHubs.ServiceDirectory.Shared.Dto;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.Extensions.Primitives;
-using Microsoft.AspNetCore.Authorization;
 using FamilyHubs.Referral.Web.Pages.Shared;
 using FamilyHubs.SharedKernel.Identity;
 using FamilyHubs.ServiceDirectory.Shared.Enums;
@@ -44,9 +43,7 @@ public async Task<IActionResult> OnGetAsync(string serviceId)
         ReturnUrl = StringValues.IsNullOrEmpty(referer) ? Url.Page("Search") : referer.ToString();
         LocalOffer = await _organisationClientService.GetLocalOfferById(serviceId);
 
-        if (!await _featureManager.IsEnabledAsync(FeatureFlag.VcfsServices) 
-            &&
-            LocalOffer.ServiceType == ServiceType.InformationSharing)
+        if (await ShouldDisableServiceDetailPage())
         {
             return RedirectToPage("/Error/404");
         }
@@ -84,6 +81,9 @@ public async Task<IActionResult> OnGetAsync(string serviceId)
         return (serviceScheduleAttendingTypes, LocalOffer.Schedules.FirstOrDefault());
     }
 
+    private async Task<bool> ShouldDisableServiceDetailPage() => 
+        !await _featureManager.IsEnabledAsync(FeatureFlag.VcfsServices) && LocalOffer.ServiceType == ServiceType.InformationSharing;
+
     private async Task<bool> ShouldShowConnectionRequestButton()
     {
         if (! await _featureManager.IsEnabledAsync(FeatureFlag.ConnectDashboard))