FHG-5472 Build and Test Workflow Refactor #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hypersolutions
commented
Jul 12, 2024
hypersolutions
commented
- Added a build and test template with inputs to centralize the build and test steps
- Updated the main build and test to call the workflow
Zac-Digital
reviewed
Jul 12, 2024
|
The job names are a little much, do you think you could reduce them to be something like "Build & Test Notification API" or similar? 
|
AaronJY
changed the title
AaronJY
approved these changes
Jul 15, 2024
|
LGTM. @hypersolutions I also added the Jira ticket number to the PR title, since it syncs this PR with Jira, meaning we can see all our PRs for a ticket under the Jira ticket itself. You wouldn't have known that, but just for next time! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.