Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FHB-792 : E2E Test Pipeline #338

Merged
merged 90 commits into from
Jan 13, 2025
Merged

FHB-792 : E2E Test Pipeline #338

merged 90 commits into from
Jan 13, 2025

Conversation

Zac-Digital
Copy link
Collaborator

@Zac-Digital Zac-Digital commented Jan 6, 2025

Ticket: FHB-792


This PR:

  • Adds e2e-seed-database.yml

    • This workflow runs either the Setup or Teardown script in the E2E data seeding framework project
    • It can be called manually through the GitHub UI
    • It is ran automatically whenever the E2E tests are ran to setup and teardown test data appropriately
  • Adds run-e2e-tests.yml

    • This workflow runs the E2E tests defined for Find & Manage. It will be updated to support Single Directory when applicable
    • It can be called manually through the GitHub UI
    • It is ran automatically after deployment to either Test, Test2 or Pre-Prod
    • It tears down the database, sets it up, and then runs the tests. If all test suites pass, it tears down the database at the end. If any fail, it leaves the data there for manual analysis
    • Uploads a report for Find and a report for Manage at the end which you can download and view for troubleshooting failures.
  • Modifies deploy.yml

    • Adds a step into the deployment pipeline to run the E2E tests after the UIs have deployed if the environment is Test, Test2 or Pre-Prod
  • Modifies playwright.config.ts (Find & Manage)

    • Adds HTTP Authentication to Manage for OneLogin
    • Runs the tests on Chrome, Edge, Mobile Chrome, Firefox & Safari. Firefox & Safari [Webkit] are currently using an interim workaround due to a TLS certificate error bug. Documented here: FHB-1180
  • Modifies serenity-tools (Manage)

    • Removes the loginToTestEnvironment step and replaces it with HTTP Authentication in the config file. This prevents logging sensitive values in the uploaded report.

stevesatdfe
stevesatdfe previously approved these changes Jan 10, 2025
Copy link
Collaborator

@stevesatdfe stevesatdfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment around quite a few places where we have end commas with nothing after them for ex:

},
name: 'Safari',
use: {
...devices['Desktop Safari'],
ignoreHTTPSErrors: true
},
},

Second to last },

test/manage-e2e-tests/playwright.config.ts Outdated Show resolved Hide resolved
StuwiiDev
StuwiiDev previously approved these changes Jan 10, 2025
Copy link
Collaborator

@StuwiiDev StuwiiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I can see from the github actions that the actions work

Copy link
Collaborator

@stevesatdfe stevesatdfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few places with trailing commas with nothing defined after

@Zac-Digital Zac-Digital merged commit 3bc5c36 into main Jan 13, 2025
4 of 5 checks passed
@Zac-Digital Zac-Digital deleted the FHB-792 branch January 13, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants