-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FHB-792 : E2E Test Pipeline #338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment around quite a few places where we have end commas with nothing after them for ex:
},
name: 'Safari',
use: {
...devices['Desktop Safari'],
ignoreHTTPSErrors: true
},
},
Second to last },
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I can see from the github actions that the actions work
d655f4d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a few places with trailing commas with nothing defined after
Ticket: FHB-792
This PR:
Adds
e2e-seed-database.yml
Setup
orTeardown
script in the E2E data seeding framework projectAdds
run-e2e-tests.yml
Modifies
deploy.yml
Modifies
playwright.config.ts
(Find & Manage)Modifies
serenity-tools
(Manage)loginToTestEnvironment
step and replaces it with HTTP Authentication in the config file. This prevents logging sensitive values in the uploaded report.