FHB-1238 - Bug/deds schema update bug #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2025 16:19
Updated schema to account for some fields being nullable as we may not get that data
Found issue where we need to deserialize empty strings to it's entity type
stevesatdfe
suggested changes
Jan 14, 2025
...h-shared-kernel.unit-tests/OpenReferral/Converters/WhenUsingStringToNullableTypeConverter.cs
Show resolved
Hide resolved
src/shared/shared-kernel/src/fh-shared-kernel.shared-kernel/OpenReferral/Entities/Schedule.cs
Show resolved
Hide resolved
stevesatdfe
approved these changes
Jan 15, 2025
Zac-Digital
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of issues with the deds schema. With the updates we can ingest international v3
Update schema to account for some nullable fields to match international schema. The fields are also not in our MVD. This includes a database migration from entitiy framework.
Added a custom JSON deserlalizer to handle empty strings in the JSON. This is because the schema uses strings for all except numbers.