Merge main into release-pen-test-changes
#368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: span to house sort icon Moved the sort icon to a span as per DAC recommendation on table header * fix(css): requestReferral scss fix Fix an issue where there was no way to compile application.css file without global imports * fix(css): manage admin scss compiling * chore: match govuk front end to avoid mismatch risk * chore(gulp): tiny tidy up of gulp file sd admin --------- Co-authored-by: Stuart.Maskell <[email protected]>
[FHB-832] Improve context on pagination
Merge main into release-dac-changes
* feat: update non js wording Update the non javascript wording to include the index number. Also update label text * fix: fix issue with ServicePageModel.cs check error length as some pages direct back to selves without errors, like the languages page. * fix: issue with non js language add Fixed an issue where adding a new language in non JS would non hold values correctly when going forward/backwards in journey. * chore: fix the del package in gulp * feat(DAC): UI update languages label and button Updated the Remove buttons to include an index number for JS rendered. Updated the language labels to include an index number for JS rendered. * chore: PR comment: Split into readable methods * chore: PR comment: use is not null over != * chore: PR comment - more methods Add another method to button removal for readability --------- Co-authored-by: Stuart.Maskell <[email protected]>
Add flag to reset and reseed databases
Merge main into release dac changes
Update text on button. Fix problem with observer hanging by being much more specific on what to observe.
fix: WhatLanguage
* test: WhenLanguageOnGetIsCalled * test: WhenWhatLanguageOnPostIsCalled.cs * test: post add test Also added more descriptive method names
FHB-117 feat: Add error prefix to title when error is triggered
FHB-117 : Fix Static Page
* feat: Heading and Caption Updated logic to change the heading and caption based on the users role and update UI * feat: Welcome UI Updated UI to have horizontal rule based on prototype. Also removed commented out UI elements. * chore: Update logic Update logic to throw exception on edge case. * chore: PR - Less duplication
Refactor postcode search errors to use ErrorState
* feat: VCS dashbard * test: Unit tests for dashboards * feat: La UI update * chore: small code tidy up in dashboards * refactor: remove reference to referral core proj. Added referral webs own client to get org name
…ers page Convert pages to use standard ErrorState
FHB-106 : Error to Tab Title (Manage, Organisation Journeys)
feat(Find): Update page title when showing error state
FHB-105 : Error to Tab Title (Manage, Account Journeys)
…changes Merge main into release dac changes
[FHB-1101] fix(Manage): Change heading for VCFS managers to not reference perfor…
Add Error to title in location journey
# Conflicts: # .github/workflows/deploy.yml
…changes Merge main into release dac changes
Remove underline from sort headers
Release main into release-dac-changes
) * refactor: added data test id to agree t&c continue button * refactor: added data test ids to continue buttons * refactor: changed apostrophe format * refactor adding data test id to another continue button * refactor adding data test id to another continue button * test: renamed test repo * refactor: removed old manage e2e test folder --------- Co-authored-by: Tina Gohil <[email protected]>
Fix failing IDAM maintenance tests
Merge main into release-dac-changes
Release dac changes
…352) * test: add user template test added * test: added add a user e2e test * test: added final assertions * test: added add user test * test: add user e2e test changed la name * test: removed unrequired commas and made formatting consistant between files * test: removed stray comma from playwright config --------- Co-authored-by: Tina Gohil <[email protected]>
* ci: run e2e setup and teardown scripts * wip: run once * wip: run once * ci: add permissions and dir * wip: test block * wip: test failed test run * ci: consolidate workflow * ci: consolidate workflow * ci: matrix test suites * fix: environment passthrough * wip: simulate failure condition * wip: simulate failure condition * wip: simulate failure condition * ci: conv action to workflow * ci: script name * ci: script name * ci: script name * wip: convert case * ci: reusable workflow for e2e seeding * ci: run playwright tests * fix: remove space from manage test folder * ci: upload artifact * ci: upload artifact * ci: cache playwright browser install step * ci: cache playwright browser install step * ci: cache playwright browser install step * ci: cache playwright browser install step * ci: base urls * ci: compute urls * wip: phantom run * wip: revert * ci: remove cache step as it wont work, remove some console log * ci: non-verbose logging * ci: env * refactor: revert * ci: better eof * wip: run on chrome only for now * ci: cache dependencies * ci: cache version * ci: cache version * ci: give it a run name * ci: give it a run name * chore: disable retries * feat: mask values * feat: mask values * refactor: does this work * refactor: no * ci: mask info * ci: fix cli option * wip: temp disable firefox * wip: temp disable webkit * test: update test * ci: install deps reliably * ci: add ability to manually trigger e2e test data setup and teardown * ci: add concurrency group * ci: misc * ci: misc * wip: temp * wip: temp * ci: run name * ci: add to deployment workflow * wip: dev flag * ci: dependency * ci: run on deployment workflow * ci: manual workflow for running e2e tests * ci: manual workflow for running e2e tests * ci: manual workflow for running e2e tests * ci: manual workflow for running e2e tests * ci: revert * ci: revert * ci: pick and choose test suites * ci: pick and choose test suites * ci: revert revert revert * ci: revert revert revert * ci: add to deployment workflow * ci: update secret names with prefix for grouping * ci: quotes in env files for spaces * ci: add guard clause * ci: add retries * ci: add guard clause * refactor: test condition * chore: enable mobile browsers * chore: remove mobile safari due to bug * chore: comment on browsers being commented out * chore: workaround for firefox * ci: workaround for safari * refactor: update after merge
) * added seed data for test LA * test: added vcfs org data --------- Co-authored-by: Tina Gohil <[email protected]>
) * test: add user template test added * test: added add a user e2e test * test: added final assertions * test: added add user test * test: add user e2e test changed la name * test: removed unrequired commas and made formatting consistant between files * test: removed stray comma from playwright config * test: added more add a user tests for dfe admin * test: updated locator * tests: removed code to get e2e tests running on mobile * tests: added msedge config back in * test: fixed spacing issues * test: changed la to test la --------- Co-authored-by: Tina Gohil <[email protected]>
…timisation ci(playwright): Performance Optimisation
…-main-release-pen-test-changes
stevesatdfe
approved these changes
Jan 15, 2025
Top-Cat
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.