FHB-1278: Fix E2E tests #399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesatdfe
previously approved these changes
Jan 24, 2025
Zac-Digital
reviewed
Jan 28, 2025
…playwright config
stevesatdfe
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium has updated their headless browser to be more in line with their headed browser and now in turn Google Chrome and MS Edge run in headless mode (not headed mode). Playwright has also implemented this change in their browsers in v1.49 (latest is v.1.50).
This means instead of explicitly calling out Google Chrome and MS Edge in playwright config as our browsers to test we can just call the headless chromium shell instead (previously we couldn't as that was not an accurate representation of google chrome or ms edge as they used a headed shell).
When we install Google Chrome and MS Edge using npx playwright install to run our E2E tests against we install headed and headless browsers - however the headed versions aren't needed anymore so we can change that command to npx playwright install --no-shell now.
microsoft/playwright#33566 this was my ref
Failures in manage are due to auth issues.