Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails & govuk-frontend updgrades #1003

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Rails & govuk-frontend updgrades #1003

merged 4 commits into from
Jan 31, 2024

Conversation

gpeng
Copy link
Contributor

@gpeng gpeng commented Jan 25, 2024

Context

A bunch of dependabot PRs needed a bit of finessing.

Changes proposed in this pull request

Upgrade:

  • rails
  • govuk-frontend
  • govuk_design_system_formbuilder

Guidance to review

Quite a lot of changes here including some visual differences, most notably the casing of the tag component.

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@gpeng gpeng requested a review from a team as a code owner January 25, 2024 20:22
@gpeng gpeng force-pushed the rails-govuk-frontend-updgrades branch from c3f0f7c to 7fbf3c5 Compare January 26, 2024 10:47
@gpeng
Copy link
Contributor Author

gpeng commented Jan 26, 2024

@gpeng gpeng force-pushed the rails-govuk-frontend-updgrades branch 13 times, most recently from 47f9cc7 to 92d930a Compare January 26, 2024 17:58
gpeng added 4 commits January 31, 2024 12:42
* Upgrade rails
* fix issue with removed `Date#to_s` arguments
* upgrade govuk-components
* upgrade related gems form builder etc
* Update to fix failing css build due to include of IE8 that is no
  longer part of govuk-frontend
@gpeng gpeng force-pushed the rails-govuk-frontend-updgrades branch from 92d930a to 182da23 Compare January 31, 2024 13:16
@gpeng gpeng merged commit cfadc19 into main Jan 31, 2024
11 checks passed
@gpeng gpeng deleted the rails-govuk-frontend-updgrades branch January 31, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants