Update Ruby from 3.1.1 to 3.3.0 #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method ZendeskDeleteRequest.from_csv returns nil even after successfully creating a record. This might be because of a change in behaviour in `CSV.foreach`. This causes ZendeskDeleteRequestImportForm#save to return nil even when a valid save has taken place. Fix this by explicitly returning true at the end of the method.
Later versions open up an API to change the colorscheme of the autocomplete dropdown in the Rails console.
malcolmbaig
force-pushed
the
1727-ruby-upgrade-3.3.0
branch
from
79a7e81 to
bec732c
Compare
steventux
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ruby 3.3.0 is available.
Changes proposed in this pull request
Upgrade ruby in .tool-versions
Update Gemfile
Update docker file. Use 3.3.0-alpine for build and runtime images
Update bundler version in Gemfile.lock to fix deprecation warnings
Guidance to review
Checklist