Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Send message to Slack on failed deploy #1044

Closed
wants to merge 4 commits into from

Conversation

malcolmbaig
Copy link
Contributor

Context

Changes proposed in this pull request

Guidance to review

Link to Trello card

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@malcolmbaig malcolmbaig requested a review from a team as a code owner February 29, 2024 11:48
@malcolmbaig malcolmbaig force-pushed the 1839-deploy-failures-in-slack branch from 63ebeff to 187ab89 Compare February 29, 2024 12:08
The CI process for Find doesn't currently post a Slack message if a
deploy fails, like we do in other services.

To implement this, begin by copying over the job definition from
Children's barred list. This will need modifying to work with Find's
particular Azure keyvault structure before it will function correctly.
Given the job definition comes from Children's barred list, we need to
amend some of its details so it works with Find.

Specifically, Find doesn't currently store its secrets as YAML like
other services do. We need to change the way we retrieve the
SLACK_WEBHOOK secret from the Find infrastructure vault.
@malcolmbaig malcolmbaig force-pushed the 1839-deploy-failures-in-slack branch from 187ab89 to c7902ba Compare March 4, 2024 13:47
@malcolmbaig malcolmbaig force-pushed the 1839-deploy-failures-in-slack branch from c7902ba to 43be3f3 Compare March 4, 2024 13:50
@malcolmbaig
Copy link
Contributor Author

Superseded by this PR: #1048

@malcolmbaig malcolmbaig closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant