Clean up Makefile #1055
Merged
Clean up Makefile #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of the keyvault printing / editing jobs work: - They invoke a configuration job read-keyvault-config that isn't defined. - Even if it was defined, the jobs would still fail because the Find app keyvault isn't structured like it is for other services. Specifically, it doesn't hold secrets in a serialized data structure sitting behind a single secret name defined in Azure. As secrets can be added and updated via the Azure portal, simply remove these jobs for now.
These are jobs and scripts that were used when Find was still deployed to GOVUK PaaS. They are no longer required now that Find deploys to AKS.
malcolmbaig
requested review from
steventux,
a team and
saliceti
and removed request for
a team
malcolmbaig
commented
Mar 27, 2024
| cf target -s ${SPACE} > /dev/null | ||
| cf rename-service ${POSTGRES_DATABASE_NAME} ${POSTGRES_DATABASE_NAME}-$(NEW_NAME_SUFFIX) | ||
|
|
||
| restore-data-from-backup: read-deployment-config # make production restore-data-from-backup CONFIRM_RESTORE=YES BACKUP_FILENAME="find-a-lost-trn-production-pg-svc-2022-04-28-01" |
There was a problem hiding this comment.
Not 100% sure about this one - ok to delete?
There was a problem hiding this comment.
100% yes
We will create a new solution for DR soon
saliceti
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There's some old and/or broken stuff in the Makefile.
Changes proposed in this pull request
Remove keyvault-related jobs from Makefile
None of the keyvault printing / editing jobs work:
defined.
app keyvault isn't structured like it is for other services. Specifically,
it doesn't hold secrets in a serialized data structure sitting behind
a single secret name defined in Azure.
As secrets can be added and updated via the Azure portal, simply remove
these jobs for now.
Remove old PaaS jobs from Makefile
These are jobs and scripts that were used when Find was still deployed
to GOVUK PaaS. They are no longer required now that Find deploys to AKS.
Guidance to review
Link to Trello card
https://trello.com/c/p5jfJKQF/1840-update-finds-key-vault-and-update-makefile
Checklist