Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console command to Makefile #1058

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Add console command to Makefile #1058

merged 1 commit into from
Apr 9, 2024

Conversation

malcolmbaig
Copy link
Contributor

@malcolmbaig malcolmbaig commented Apr 4, 2024

Context

Conveniently access a console on any of the deployed environments from our dev machines. Requires appropriate permissions set up in Azure.

Changes proposed in this pull request

Add a console job based on similar implementation in CBL.

Guidance to review

Can be tested locally with (for example) make development console.

Link to Trello card

https://trello.com/c/p5jfJKQF/1840-update-finds-makefile-and-document-how-to-update-its-key-vault

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

Conveniently access a console on any of the deployed environments from
our dev machines. Requires appropriate permissions set up in Azure.
@malcolmbaig malcolmbaig requested a review from a team as a code owner April 4, 2024 08:33
@malcolmbaig malcolmbaig requested review from steventux, a team and johnake and removed request for a team April 4, 2024 08:40
Copy link
Contributor

@richardpattinson richardpattinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@malcolmbaig malcolmbaig merged commit 0c028b7 into main Apr 9, 2024
12 checks passed
@malcolmbaig malcolmbaig deleted the 1840-update-makefile branch April 9, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants