[1812] Stop okcomputer logging #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It creates 5 log entries for each healthcheck, which is currently 1 per second on kubernetes. But this is not that useful.
|
AKS review app deployed to https://find-a-lost-trn-review-pr-1088.test.teacherservices.cloud |
We're only using Semantic Logger in production, so return early from the initializer if the constant defined by the gem is missing.
johnake
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Reduce the quantity of generated logs
Changes proposed in this pull request
Stop logging forom the okcomputer healthcheck
Guidance to review
Check logs for this review app in Logit
Link to Trello card
https://trello.com/c/bjfo0jo9
Checklist