Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code clean up - Find a lost TRN #981

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

johnake
Copy link
Contributor

@johnake johnake commented Dec 28, 2023

Context

Code clean up - Find a lost TRN
The code was duplicated during the migration so we could run the apps on AKS alongside PaaS. All the PaaS specific code should now be removed for clarity.

Changes proposed in this pull request

PaaS specific code to be removed for:

  • Terraform paas code
  • Terraform paas environments
  • Github workflows
  • Github actions
  • Makefile commands
  • Github secrets
  • Azure resources
  • Update Readme
  • Update documentation (/docs, /documentation, confluence...)
  • Remove "v2" and "aks" suffix in actions, workflows, labels, make commands...

Guidance to review

Include any useful information needed to review this change.
Include any dependencies that are required for this change.

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@johnake johnake requested a review from a team as a code owner December 28, 2023 10:57
Makefile Show resolved Hide resolved
@johnake johnake force-pushed the 837-code-clean-up-find-a-lost-trn branch from 53d98be to 670b404 Compare December 29, 2023 13:22
@johnake
Copy link
Contributor Author

johnake commented Dec 29, 2023

@johnake johnake changed the title WIP Code clean up - Find a lost TRN Dec 29, 2023
@johnake
Copy link
Contributor Author

johnake commented Dec 29, 2023

@johnake johnake force-pushed the 837-code-clean-up-find-a-lost-trn branch from 670b404 to ee45055 Compare December 29, 2023 14:11
@johnake johnake force-pushed the 837-code-clean-up-find-a-lost-trn branch from ee45055 to 7ff2d64 Compare December 29, 2023 14:19
@johnake johnake force-pushed the 837-code-clean-up-find-a-lost-trn branch from 7ff2d64 to 9f98448 Compare December 29, 2023 15:57
@johnake johnake force-pushed the 837-code-clean-up-find-a-lost-trn branch from 9f98448 to d19933f Compare December 29, 2023 16:09
@johnake johnake force-pushed the 837-code-clean-up-find-a-lost-trn branch from d19933f to c7ccbe3 Compare December 29, 2023 16:15
@johnake johnake force-pushed the 837-code-clean-up-find-a-lost-trn branch from c7ccbe3 to cc0baa4 Compare January 1, 2024 19:31
@johnake johnake force-pushed the 837-code-clean-up-find-a-lost-trn branch from cc0baa4 to cf0e613 Compare January 1, 2024 19:41
Copy link

github-actions bot commented Jan 2, 2024

AKS review app deployed to

@johnake johnake merged commit ba03f50 into main Jan 3, 2024
11 checks passed
@johnake johnake deleted the 837-code-clean-up-find-a-lost-trn branch January 3, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants