Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ofsted data sources #701

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Update ofsted data sources #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb68d0d
removed date joined trust data source from ofsted page source list, a…
Jan 22, 2025
b7b4187
updated changelog
Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
## [Unreleased][unreleased]

- Updated accessibility statement text
- Removed 'Date joined trust' from Ofsted data source list

## [Release-19][release-19] (production-2025-01-20.4730)

Expand Down
3 changes: 0 additions & 3 deletions DfE.FindInformationAcademiesTrusts/Pages/Trusts/Ofsted/OfstedAreaModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,11 @@ public override async Task<IActionResult> OnGetAsync()

DataSourcesPerPage.AddRange([
new DataSourcePageListEntry(ViewConstants.OfstedCurrentRatingsPageName, [
dateJoinedTrust,
new DataSourceListEntry(misDataSource, "Current Ofsted rating"),
new DataSourceListEntry(misDataSource, "Date of current inspection")
]
),
new DataSourcePageListEntry(ViewConstants.OfstedPreviousRatingsPageName, [
dateJoinedTrust,
new DataSourceListEntry(misDataSource, "Previous Ofsted rating"),
new DataSourceListEntry(misDataSource, "Date of previous inspection")
]
Expand All @@ -75,7 +73,6 @@ public override async Task<IActionResult> OnGetAsync()
]
),
new DataSourcePageListEntry(ViewConstants.OfstedSafeguardingAndConcernsPageName, [
dateJoinedTrust,
new DataSourceListEntry(misDataSource, "Effective safeguarding"),
new DataSourceListEntry(misDataSource, "Category of concern"),
new DataSourceListEntry(misDataSource, "Date of current inspection")
Expand Down
3 changes: 0 additions & 3 deletions .../DfE.FindInformationAcademiesTrusts.UnitTests/Pages/Trusts/Ofsted/OfstedAreaModelTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,11 @@ public async Task OnGetAsync_sets_correct_data_source_list()
_sut.DataSourcesPerPage.Count.Should().Be(4);
_sut.DataSourcesPerPage.Should().BeEquivalentTo([
new DataSourcePageListEntry(ViewConstants.OfstedCurrentRatingsPageName, [
new DataSourceListEntry(_giasDataSource, "Date joined trust"),
new DataSourceListEntry(_misDataSource, "Current Ofsted rating"),
new DataSourceListEntry(_misDataSource, "Date of current inspection")
]
),
new DataSourcePageListEntry(ViewConstants.OfstedPreviousRatingsPageName, [
new DataSourceListEntry(_giasDataSource, "Date joined trust"),
new DataSourceListEntry(_misDataSource, "Previous Ofsted rating"),
new DataSourceListEntry(_misDataSource, "Date of previous inspection")
]
Expand All @@ -82,7 +80,6 @@ public async Task OnGetAsync_sets_correct_data_source_list()
]
),
new DataSourcePageListEntry(ViewConstants.OfstedSafeguardingAndConcernsPageName, [
new DataSourceListEntry(_giasDataSource, "Date joined trust"),
new DataSourceListEntry(_misDataSource, "Effective safeguarding"),
new DataSourceListEntry(_misDataSource, "Category of concern"),
new DataSourceListEntry(_misDataSource, "Date of current inspection")
Expand Down
Loading