Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the account page from the placement service #1083

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Remove the account page from the placement service #1083

merged 3 commits into from
Oct 14, 2024

Conversation

JamieCleare2525
Copy link
Contributor

Context

  • Remove the account page from the placements service

Changes proposed in this pull request

  • Remove 'Account' nav item from the header
  • Remove '/account` from the routes for placements service

Guidance to review

  • Sign in as any user on the placements service
  • The 'Account' item in the header nav should no longer appear.
  • visiting /account should no longer work for the placements service.

Link to Trello card

https://trello.com/c/fsvC2q4R/858-remove-the-account-page-from-the-placements-service

Screenshots

Screenshot 2024-10-04 at 15 37 11

@JamieCleare2525 JamieCleare2525 added the deploy A Review App will be created for PRs with this label label Oct 4, 2024
@JamieCleare2525 JamieCleare2525 self-assigned this Oct 4, 2024
@JamieCleare2525 JamieCleare2525 requested review from a team as code owners October 4, 2024 14:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

Review app track and pay deployed to https://track-and-pay-1083.test.teacherservices.cloud was deleted
Review app school placements deployed to https://manage-school-placements-1083.test.teacherservices.cloud was deleted

Kizr
Kizr approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@Kizr Kizr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but mostly opinion based, nothing blocking!

app/views/layouts/application.html.erb Outdated Show resolved Hide resolved
config/routes.rb Outdated Show resolved Hide resolved
spec/system/placements/sign_in_as_a_placements_user_spec.rb Outdated Show resolved Hide resolved
@JamieCleare2525 JamieCleare2525 mentioned this pull request Oct 14, 2024
Merged
@JamieCleare2525 JamieCleare2525 requested a review from Kizr October 14, 2024 10:55
@JamieCleare2525 JamieCleare2525 merged commit a71e9f5 into main Oct 14, 2024
8 checks passed
@JamieCleare2525 JamieCleare2525 deleted the jc/remove_account_page_from_placements_service branch October 14, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kizr Kizr Kizr approved these changes

Assignees

@JamieCleare2525 JamieCleare2525

Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieCleare2525 @Kizr