Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create reusable sign in test helpers #1120

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Create reusable sign in test helpers #1120

merged 1 commit into from
Oct 29, 2024

Conversation

JamieCleare2525
Copy link
Contributor

Context

  • Make reusable helper methods to sign in placements users and support users in test suite.

Changes proposed in this pull request

  • Create a helper method to sign in Placements Support Users
  • Create a helper method to sign in Placements Users (School/Provider Users)
  • Replace methods within test suite with the new helpers.

Guidance to review

  • Review the code.
  • Run parallel_rspec and make sure nothing is broken.

Link to Trello card

https://trello.com/c/njUXh2LV/869-create-reusable-test-helpers-for-common-sign-in-behaviour

@JamieCleare2525 JamieCleare2525 self-assigned this Oct 21, 2024
@JamieCleare2525 JamieCleare2525 requested review from a team as code owners October 21, 2024 14:38
@JamieCleare2525 JamieCleare2525 force-pushed the jc/create_reusable_sign_in_test_helpers branch 4 times, most recently from 5b2d22e to 8f6d0e1 Compare October 25, 2024 15:38
ollietreend
ollietreend approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@ollietreend ollietreend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

+222 -1,106 lines of code

@JamieCleare2525 JamieCleare2525 force-pushed the jc/create_reusable_sign_in_test_helpers branch from 8f6d0e1 to 8471b3e Compare October 29, 2024 14:46
@JamieCleare2525 JamieCleare2525 merged commit 5fb1088 into main Oct 29, 2024
8 checks passed
@JamieCleare2525 JamieCleare2525 deleted the jc/create_reusable_sign_in_test_helpers branch October 29, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ollietreend ollietreend ollietreend approved these changes

Assignees

@JamieCleare2525 JamieCleare2525

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieCleare2525 @ollietreend