Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jc/refactor claims to wizard pattern #1188

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Jc/refactor claims to wizard pattern #1188

wants to merge 8 commits into from

Conversation

JamieCleare2525
Copy link
Contributor

Context

  • Refactor so the multi-step form used to add a claim, now uses the AddClaimWizard

Changes proposed in this pull request

  • Add an AddClaimWizard, including steps for each part of the multi-step process.
  • Refactor necessary components and views to use the AddClaimWizard

Guidance to review

  • Sign in as Anne (School User)
  • Run through the process of adding a claim. (Make sure everything works as expected)
  • Sign in as Colin (Support User)
  • Run through the process of adding a claim. (Make sure everything works as expected)

Link to Trello card

https://trello.com/c/MhC5trwI/922-refactor-the-add-claim-form-to-use-the-wizard-pattern?filter=label:Development

@JamieCleare2525 JamieCleare2525 added the deploy A Review App will be created for PRs with this label label Nov 19, 2024
@JamieCleare2525 JamieCleare2525 self-assigned this Nov 19, 2024
@github-actions GitHub Actions
Copy link

Deployments

App URL
Track & Pay https://track-and-pay-1188.test.teacherservices.cloud
School Placements https://manage-school-placements-1188.test.teacherservices.cloud

@JamieCleare2525 JamieCleare2525 marked this pull request as ready for review November 20, 2024 15:49
@JamieCleare2525 JamieCleare2525 requested review from a team as code owners November 20, 2024 15:49
ollietreend
ollietreend reviewed Nov 21, 2024
View reviewed changes
app/controllers/claims/support/schools/claims/add_claim_controller.rb Outdated Show resolved Hide resolved
app/policies/claims/claim_policy.rb Outdated Show resolved Hide resolved
app/services/claims/claim/create_draft.rb Outdated Show resolved Hide resolved
app/services/claims/claim/submit.rb Outdated Show resolved Hide resolved
app/views/claims/schools/claims/index.html.erb Show resolved Hide resolved
config/locales/en/activemodel.yml Outdated Show resolved Hide resolved
config/routes/claims.rb Outdated Show resolved Hide resolved
config/routes/claims.rb Outdated Show resolved Hide resolved
config/routes/claims.rb Outdated Show resolved Hide resolved
spec/wizards/claims/add_claim_wizard_spec.rb Outdated Show resolved Hide resolved
ollietreend
ollietreend approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@ollietreend ollietreend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Looks good to me! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ollietreend ollietreend ollietreend approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@JamieCleare2525 JamieCleare2525

Labels
deploy A Review App will be created for PRs with this label DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieCleare2525 @ollietreend