Add phase filter to placements search

[dp-daly]

Context

This design change allows provider users to find placements in Primary or Secondary more easily.

Changes proposed in this pull request

• Add a phase filter option to the filter menu on the placements index.
• Add an accompanying filter tag when a phase filter is selected.
• Add functionality that changes other filter options depending on whether a phase filter has been selected (see expected behaviour below).
• Add system spec for new phase filter.
• Update filter form spec to include tests for expected phase filter behaviour.

Guidance to review

• Toggle the phase filter options and test it against the below expected behaviour.
• Review new system spec and changes to filter form spec.

When no checkboxes are selected (default state)

• Search results: Show both primary and secondary placements in the results
• “Subject” filter: Show both primary and secondary subjects in the list of options
• “Primary year group” filter: Show this filter
• “School” filter: Show both primary and secondary schools in the list of options

When only Primary is selected

• Search results: Only show placements for primary subjects
• “Subject” filter: Only show primary subjects in the list of options
• “Primary year group” filter: Show this filter
• “School” filter: Exclude secondary schools from the list of options

When only Secondary is selected

• Search results: Only show placements for secondary subjects
• “Subject” filter: Only show secondary subjects in the list of options
• “Primary year group” filter: Hide this filter
• “School” filter: Exclude primary schools from the list of options

When both Primary and Secondary are selected

Same behaviour as when no checkboxes are selected (default state) ☝️

Link to Trello card

https://trello.com/c/oCkrtGGU/951-add-a-phase-filter-to-placements-search

Screenshots

Screen.Recording.2024-11-27.at.16.53.24.mov

[github-actions]

Deployments

App	URL
Track & Pay	https://track-and-pay-1211.test.teacherservices.cloud
School Placements	https://manage-school-placements-1211.test.teacherservices.cloud

[JamieCleare2525]

Rather and putting this here. Consider putting this as part of the schools_scope method.

[dp-daly]

@JamieCleare2525 I haven't been able to incorporate this without affecting the initialization of @schools across the app 🤔 I thought this would work but it didn't:

  def schools_scope
    if filter_params[:only_partner_schools].present?
      @schools = @provider.partner_schools
    else
      @schools = Placements::School.all
    end
    
    filter_schools_by_phase
  end

I get 58 instances of an error saying that .order_by_name can't act on nil.