Refactor add mentor spec #1222
Merged
Refactor add mentor spec #1222
+677
−354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dp-daly
force-pushed
the
dpd/refactor-add-mentor-school-system-spec
branch
2 times, most recently
from
93f0a43 to
4467823
Compare
Kizr
requested changes
Dec 3, 2024
spec/system/placements/schools/mentors/add_a_mentor_with_multi_tabs_spec.rb
Outdated
Show resolved
Hide resolved
spec/system/placements/schools/mentors/add_a_mentor_with_multi_tabs_spec.rb
Outdated
Show resolved
Hide resolved
spec/system/placements/schools/mentors/add_a_mentor_with_multi_tabs_spec.rb
Outdated
Show resolved
Hide resolved
spec/system/placements/schools/mentors/add_an_existing_claims_mentor_spec.rb
Outdated
Show resolved
Hide resolved
spec/system/placements/schools/mentors/add_an_existing_mentor_spec.rb
Outdated
Show resolved
Hide resolved
spec/system/placements/schools/mentors/find_a_mentor_with_no_results_spec.rb
Outdated
Show resolved
Hide resolved
spec/system/placements/schools/mentors/find_a_mentor_with_no_results_spec.rb
Outdated
Show resolved
Hide resolved
dp-daly
force-pushed
the
dpd/refactor-add-mentor-school-system-spec
branch
from
4467823 to
674ce28
Compare
Kizr
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have agreed as a team that we'd like to pursue a new style of system specs to bring our organically (home baked) system specs in line and identify any gaps in their testing.
Changes proposed in this pull request
Adds four new spec files in the new style to replace the previous
add_a_mentor_spec, these are:Guidance to review
Review the spec files and look for any missed scenarios or elements that are important to an end user.
Link to Trello card
https://trello.com/c/EMmoKsub/964-refactor-add-mentor-school-system-tests