Create views for claim activity #1347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/views/claims/support/claims/claim_activities/_manual_activities.html.erb
Outdated
Show resolved
Hide resolved
app/views/claims/support/claims/claim_activities/_payment_and_clawback_activities.html.erb
Outdated
Show resolved
Hide resolved
app/views/claims/support/claims/claim_activities/_sampling_activities.html.erb
Outdated
Show resolved
Hide resolved
Includes addition of new mailers, services and updated test logic
Deployments
|
app/controllers/claims/support/claims/claim_activities_controller.rb
Outdated
Show resolved
Hide resolved
|
|
||
| <h2 class="govuk-heading-m"><%= t(".providers") %></h2> | ||
|
|
||
| <% claim_activity.record.claims.group_by(&:provider).each do |provider, provider_claims| %> |
There was a problem hiding this comment.
Personal preference: I'm not a fan of seeing group_by in a view. Could we extract this to the Claims::ClaimActivity model?
There was a problem hiding this comment.
I'd normally agree but in this case it's specific to certain types claim activity so it would error when used outside this particular scope, any suggestions for where it should live based on this?
There was a problem hiding this comment.
I would still argue it belongs in the model. Even with a try or guard clause for the cases when it `shouldn't (but probably should) work.
Kizr
force-pushed
the
ba/add-audit-screens
branch
from
ee57128 to
8d7e50b
Compare
Kizr
force-pushed
the
ba/add-audit-screens
branch
from
8d7e50b to
5ed56bb
Compare
Comment on lines
21
to
37
| case claim_activity.action | ||
| when "payment_request_delivered" | ||
| Claims::Payment::ResendEmail.call(payment: claim_activity.record) | ||
| when "clawback_request_delivered" | ||
| Claims::Clawback::ResendEmail.call(clawback: claim_activity.record) | ||
| else | ||
| raise "Unknown action: #{claim_activity.action}" | ||
| end | ||
|
|
||
| authorize [:claims, claim_activity] | ||
| redirect_to claims_support_claims_claim_activity_path(claim_activity), flash: { success: true, heading: t(".success") } | ||
| end | ||
|
|
||
| def resend_provider_email | ||
| Claims::Sampling::ResendEmails.call(provider_sampling:) | ||
|
|
||
| authorize [:claims, claim_activity] |
There was a problem hiding this comment.
Still a couple of authorize calls need to be moved. Otherwise you send emails they might not be allowed to.
Kizr
force-pushed
the
ba/add-audit-screens
branch
from
9da9ac1 to
82153d1
Compare
JamieCleare2525
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The activity log was not particularly useful for our users, so we have expanded the information available on the page.
Changes proposed in this pull request
Guidance to review
Link to Trello card
Create audit log screens
Screenshots