Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make casing consistent to match Cypress test expectation #977

Closed
wants to merge 1 commit into from
Closed

Make casing consistent to match Cypress test expectation #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ects/Dfe.ManageFreeSchoolProjects/Pages/Project/Create/Individual/CheckYourAnswers.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

var faithType = Model.Project.FaithType == FaithType.Other ? $"Other - {Model.Project.OtherFaithType}" : Model.Project.FaithType.ToDescription();
var faithTypeLink = Model.Project.FaithStatus == FaithStatus.None ? RouteConstants.CreateFaithStatus : RouteConstants.CreateFaithType;

var ageRangeValue = string.Empty;
var projectAgeRange = Model.Project.AgeRange;
if (projectAgeRange.Contains('-'))
Expand Down Expand Up @@ -47,7 +47,7 @@
@RenderSummaryRow("Application wave", Model.Project.ApplicationWave, RouteConstants.CreateApplicationWave)
}

@RenderSummaryRow("Temporary project ID", Model.Project.ProjectId, RouteConstants.CreateProjectId)
@RenderSummaryRow("Temporary Project ID", Model.Project.ProjectId, RouteConstants.CreateProjectId)
@RenderSummaryRow("Current free school name", Model.Project.SchoolName, RouteConstants.CreateProjectSchool)


Expand Down Expand Up @@ -116,4 +116,4 @@
return new HtmlString(htmlString);
}

}
}
6 changes: 3 additions & 3 deletions ...Projects/Dfe.ManageFreeSchoolProjects/Pages/Project/Create/Individual/Confirmation.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@page "/project/create/confirmation"
@model Dfe.ManageFreeSchoolProjects.Pages.Project.Create.Individual.ConfirmationModel
@{
ViewData["Title"] = "Confirmation";
ViewData["Title"] = "Confirmation";
}

<div class="govuk-grid-row">
Expand All @@ -11,7 +11,7 @@
Free school project created
</h1>
<div class="govuk-panel__body">
Temporary project ID<br><strong data-testid="created-project-id" >@Model.ProjectID</strong>
Temporary Project ID<br><strong data-testid="created-project-id" >@Model.ProjectID</strong>
</div>
</div>
<p data-testid="confirmation-email">
Expand All @@ -24,4 +24,4 @@
<a class="govuk-link" href="/">Go back to the projects listing page</a> and see the newly created project.
</p>
</div>
</div>
</div>
4 changes: 2 additions & 2 deletions ...oolProjects/Dfe.ManageFreeSchoolProjects/Pages/Project/Create/Individual/ProjectId.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@page "/project/create/projectid"
@model Dfe.ManageFreeSchoolProjects.Pages.Project.Create.Individual.ProjectIdModel
@{
ViewData["Title"] = "What is the temporary project ID?";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I checked manually the title is What is the temporary project ID? , so this seems correct.
test env title

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case we need to check the Cypress Test because it is likely checking for title case

ViewData["Title"] = "What is the Temporary Project ID?";
}
@section BeforeMain {
<div role="navigation" class="govuk-width-container">
Expand All @@ -14,7 +14,7 @@
<form class="form" method="post">

<div class="govuk-form-group">
<govuk-create-title label="What is the temporary project ID?" for="projectid" />
<govuk-create-title label="What is the Temporary Project ID?" for="projectid" />
<govuk-text-input id="projectid" name="projectid" asp-for="@Model.ProjectId" data-testid="projectid" hint="For example, W3456" />
</div>

Expand Down
Loading